design(mytasks): remove stray divider lines from the group-by segment - #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-polish pass — a mobile-zoom defect hunt on My Tasks surfaced stray vertical lines in the "Group by" segment. Between the tabs (Priority | Focus | Project | Label) sat thin divider rules that read as leftover artifacts in what's meant to be a clean pill-style toggle.
Root cause
Ionic's iOS
ion-segment-buttondraws an inter-button divider via its shadow-DOM:host::before(aborder-left), controlled by the documented--border-colorcustom property.Fix (CSS-only, tokens only)
Set
--border-color: transparenton.mytasks__group ion-segment-buttonto drop the dividers. The segment now reads as a clean toggle — active state intact (blue underline on desktop, white pill on mobile). No divider lines on either viewport.Before → after
Full quality gate green (85 My Tasks tests pass); presentational-only. Verified against the sandbox (
AWS_PROFILE=personal).